Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text Editor Doesn't Support Multi Paragraph Edits #1291

Closed
willisplummer opened this issue May 28, 2018 · 3 comments
Closed

Rich Text Editor Doesn't Support Multi Paragraph Edits #1291

willisplummer opened this issue May 28, 2018 · 3 comments
Assignees
Labels
issue: feature request Issue suggesting a new feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve

Comments

@willisplummer
Copy link

Informations

  • Node.js version: 9.11.1:
  • npm version: 5.6.0:
  • Strapi version: 3.0.0-alpha.12.2:
  • Database: MongoDB:
  • Operating system:

What is the current behavior?
Highlighting multiple paragraphs of text and clicking bold erases the highlighted text and replaces with the string **bold text**.

Steps to reproduce the problem
Highlight multiple paragraphs of text and click bold

What is the expected behavior?
Should apply bold styling to the entire highlighted region or just be disabled if that's not supported.

Suggested solutions
I haven't worked with DraftJS in a little while but I believe that this is a fairly common issue related to how it separates paragraphs into unique content blocks and then applies text styling on a per block basis?

@soupette soupette self-assigned this May 28, 2018
@soupette soupette added issue: enhancement Issue suggesting an enhancement to an existing feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve labels May 29, 2018
@lauriejim
Copy link
Contributor

Hello @willisplummer , thank you for reporting this issue. We are currently on another feature and bug fix. Since time is lacking on our side, feel free investigate and submit a PR, we’ll appreciate your contribution on this issue!

Check out the contributing guide to get started: https://github.com/strapi/strapi/blob/master/.github/CONTRIBUTING.md

@soupette
Copy link
Contributor

soupette commented Jun 6, 2018

@willisplummer In fact it's logic itself that needs to be improved.

The bug is that instead of inserting ** at both ends of the paragraph I set at the line's ones.

@lauriejim lauriejim assigned Aurelsicoko and unassigned soupette Aug 22, 2018
@lauriejim lauriejim added issue: feature request Issue suggesting a new feature and removed issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 22, 2018
@Aurelsicoko
Copy link
Member

I'm closing this issue, please refers to this public card on Product Board (see https://portal.productboard.com/strapi/c/37-wysiwyg-html-editor). Even if the title doesn't express that we'll change the editor, we will certainly take a look at free & open-source alternatives like Froala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Issue suggesting a new feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve
Projects
None yet
Development

No branches or pull requests

4 participants