-
Notifications
You must be signed in to change notification settings - Fork 88
Fix Caller Parameter in PFM verify #119
Fix Caller Parameter in PFM verify #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @kingster-will can you review please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block it for now, need further clarification
The current title of the PR does not accurately convey the nature of the changes made. These modifications are not directly related to the HookModule. Instead, the primary focus is on ensuring the correct NFT holder is identified during the process of commercializer verification. A more descriptive title would better reflect this specific change. |
* feat: Deployment script for latest contracts * nit: New Deployment after rebase #119
* fix: pass in licensee (license holder) to verify calls in PFM * test: Commercializer checker test in Integration * fix: verifyMint caller parameter in license minting
* feat: Deployment script for latest contracts * nit: New Deployment after rebase storyprotocol#119
address holder
to internal function_linkIpToParent
verifyMint
called insideLicensingModule.mintLicense()
Closes #117