Resolve Cyclical Dependencies in Contract Deployment Using CREATE3

[kingster-will]

Issue Description

We are currently facing challenges with cyclical dependencies among our smart contracts. The ideal approach to address this issue would be to pass the dependent contract addresses directly to the constructors during deployment, allowing us to store these addresses as immutable state variables. However, due to the existing cyclical dependencies, this straightforward approach is not feasible with our current deployment method.

Proposed Solution

To resolve the cyclical dependencies during the deployment of our smart contracts, it is proposed to utilize CREATE3. CREATE3 allows for deploying contracts to deterministic addresses using only a salt. This method would enable us to:

• Deploy all contracts with cyclical dependencies to known, deterministic addresses.
• Directly pass these addresses to constructors, thereby storing them as immutable variables within the contract.
• Remove the need for governance functions previously used to set these addresses, thereby simplifying our protocol.

Benefits

• Immutable Storage: By deploying using CREATE3, the addresses of dependent contracts can be hardcoded as immutable
• Simplification of Protocol: Eliminates the need for governance actions to set contract addresses post-deployment, which simplifies interaction and reduces potential errors.