Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null elements in getData #926

Merged
merged 3 commits into from
Apr 28, 2017
Merged

Conversation

methyl
Copy link
Contributor

@methyl methyl commented Apr 21, 2017

Null is valid element in React, so let's handle it and return no data in this case.

Issue: When rendering null inside story with addWithInfo, exception is thrown.

How to test

storiesOf('Test').addWithInfo('test', '', () => <div>{null}</div>)

methyl and others added 2 commits April 21, 2017 14:16
Null is valid element in React, so let's handle it and return no data in this case.
@ndelangen
Copy link
Member

Thanks @methyl, I will merge this !

@ndelangen ndelangen self-assigned this Apr 28, 2017
@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #926 into master will decrease coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   26.88%   26.87%   -0.01%     
==========================================
  Files         192      192              
  Lines        4375     4380       +5     
  Branches      700      701       +1     
==========================================
+ Hits         1176     1177       +1     
- Misses       3199     3203       +4
Impacted Files Coverage Δ
packages/addon-info/src/components/Node.js 21.25% <25%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0313a1...25971c4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants