-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript definitions for getStorybook() #753
Conversation
`2.35.3` add `getStorybook()` in 86d5819, but Typescript definitions were not updated.
config/storybook.d.ts
Outdated
render: RenderFunction, | ||
}; | ||
|
||
type StoryBucket = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure about the naming here, happy to take any suggestion.
Updated to not overwrite the changes from #680 |
@ndelangen any chance to get this in if I rebase it again? |
Yeah, I think so! |
👍 @ndelangen rebased! |
ta! |
any chance to get this in a release @ndelangen? |
Yes this will get released in 3.0.0, I don't have a date for that yet, should be an alpha release soonish. My guess this at the end of this month or in the beginning of next month. |
2.35.3
addgetStorybook()
in 86d5819, but Typescript definitions were not updated.Also
configure
was missing altogether, added in 0e9d7deIssue:
when using
getStorybook()
.What I did
Added TS definition.
How to test
Run
test.ts
, e.g.:with
tsc
.