-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate @storybook/addon-knobs to typescript #7180
Migrate @storybook/addon-knobs to typescript #7180
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-emilio-martinez-ts-migration-addon-knobs.storybook.now.sh |
@emilio-martinez to answer your question #5030 (comment), you can add |
9454545
to
c536ba4
Compare
c536ba4
to
2547cf1
Compare
2547cf1
to
8535624
Compare
35ddfa9
to
fd2d168
Compare
fd2d168
to
b78f4c9
Compare
b78f4c9
to
404060c
Compare
404060c
to
b11e833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @emilio-martinez ! Just a few comments you can simply resolve in a new commit 😉
This commit simply transitions the files from js to ts to make the commit history clearer afterwards. Expected not to type-check.
b092448
to
7d1fe63
Compare
@gaetanmaisse feedback addressed. FYI, I rebased to resolve a merge conflict. DeepScan is calling out REACT_MISUSED_UPDATE_IN_SET_STATE, but I'd prefer to tackle in a separate PR once this is merged, if that's okay. |
Hi. I've just upgraded to SB 5.2 and my build is failing due to a TS error in addon-knobs. Something about react-color missing? |
@sami616 Can you file an issue and include the details? We'll try to get you fixed up. |
Issue: #5030
What I did
Migrate @storybook/addon-knobs to typescript.
**Note: ** To make this easier to review, I did an initial commit with a straight file rename from js => ts, and subsequent commits will add the types accordingly.
How to test
If all works correctly, functionally nothing should change to lib consumers beyond getting a typed package.