Fix/syntaxthighlighter themes #6814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
danielduan,
igor-dv,
tmeasday and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-syntaxthighlighter-themes.storybook.now.sh |
ndelangen
force-pushed
the
fix/syntaxthighlighter-themes
branch
from
165e3d1 to
6d90164
Compare
ndelangen
force-pushed
the
fix/syntaxthighlighter-themes
branch
from
6d90164 to
e32df27
Compare
ndelangen
force-pushed
the
fix/syntaxthighlighter-themes
branch
from
648a088 to
c743340
Compare
# Conflicts: # lib/components/package.json # yarn.lock
shilman
requested changes
May 19, 2019
|
THank for the review @shilman, I extracted the function into it's own module and added tests |
ndelangen
force-pushed
the
fix/syntaxthighlighter-themes
branch
from
2bf1ead to
fcc12c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6797
What I did
I fixed issues with theming, typing & syntaxhighlighter component to make sure that the component will have a proper color & fixed the indentation & decreased the bundlesize while I was at it.