Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make return type of StoryDecorator nullable #680

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Make return type of StoryDecorator nullable #680

merged 1 commit into from
Mar 29, 2017

Conversation

pablobirukov
Copy link
Contributor

@pablobirukov pablobirukov commented Jan 31, 2017 •
edited
Loading

Since render() method returns JSX.Element | null, the signature of StoryDecorator breaks repos with latest React definitions and --strictNullChecks.

@ndelangen ndelangen merged commit 287c907 into storybookjs:master Mar 29, 2017
joscha added a commit to joscha/react-storybook that referenced this pull request Apr 13, 2017
@joscha
Update storybook.d.ts
dd49bda 
Incorporate storybookjs#680
@joscha joscha mentioned this pull request Apr 13, 2017
Merged
ndelangen pushed a commit that referenced this pull request May 24, 2017
@joscha @ndelangen
Update storybook.d.ts
018e29a 
Incorporate #680
@shilman shilman added the misc label May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apexskier apexskier apexskier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablobirukov @apexskier @shilman @ndelangen