Warn if story with a given name already exists #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now if you add another story with the same name, the first one is
lost. For example:
```js
// …
storiesOf('Button', module)
.add('with text', () => ( // this story will be lost
<Button onClick={action('clicked')}>Hello Button</Button>
))
.add('with some emoji', () => (
<Button onClick={action('clicked')}>😀 😎 👍 💯</Button>
))
.add('with text', () => (
<p>
this will silently overwrite the first story
</p>
));
```
arunoda
reviewed
Jan 15, 2017
| @@ -11,6 +11,10 @@ export default class StoryStore { | |||
| } | |||
|
|
|||
| addStory(kind, name, fn) { | |||
| if (this.hasStory(kind, name)) { | |||
There was a problem hiding this comment.
I like to do this check here instead of in the store.
See: https://github.com/evgenykochetkov/react-storybook/blob/01f79bc1dc96a414c89fbcd2b568894f6eebff9b/src/client/preview/client_api.js#L48
The real one in `src/client/preview/story_store.js` has this method.
apexskier
reviewed
Jan 25, 2017
| @@ -45,6 +45,10 @@ export default class ClientApi { | |||
| }); | |||
|
|
|||
| api.add = (storyName, getStory) => { | |||
| if (this._storyStore.hasStory(kind, storyName)) { | |||
| throw new Error(`Story of "${kind}" named "${storyName}" alredy exists`); | |||
There was a problem hiding this comment.
Thanks! Fixed it.
"alredy" -> "already"
apexskier
approved these changes
Jan 26, 2017
|
Thank you so much! |
|
Doesn't it break any existing projects or addons which works with stories dynamically? |
|
Do you have examples of this? If this is indeed a common thing addons do, We need to think of something else. |
|
@usulpro Do you think this is a real issue? |
This was referenced Sep 18, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you add another story with the same name, the first one is
lost. For example: