Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storiesNav): adding classNames to stories nav elements #6571

Merged
merged 1 commit into from
Apr 23, 2019
Merged

feat(storiesNav): adding classNames to stories nav elements #6571

merged 1 commit into from
Apr 23, 2019

Conversation

mbellary-chwy
Copy link
Contributor

Feature:

adding classNames to stories nav elements

What I did

  • adding classNames to stories nav elements
  • updating LogoLink to support html elements

This PR is a replacement for the deep theming PR:

#6098

@vercel
Copy link

vercel bot commented Apr 20, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-feature-add-classnames-t.storybook.now.sh

@mbellary-chwy mbellary-chwy self-assigned this Apr 20, 2019
@vercel vercel bot temporarily deployed to staging April 21, 2019 01:13 Inactive
@mbellary-chwy mbellary-chwy force-pushed the feature/add-classNames-to-stories-nav-elements branch from 785a938 to 88735c3 Compare April 21, 2019 01:14
@vercel vercel bot temporarily deployed to staging April 21, 2019 02:19 Inactive
@mbellary-chwy
feat(storiesNav): adding classNames to stories nav elements
f46a455 
- adding classNames to stories nav elements
- updating LogoLink to support html elements

This PR is a replacement for the deep theming PR:

#6098
@mbellary-chwy mbellary-chwy force-pushed the feature/add-classNames-to-stories-nav-elements branch from 074bcb3 to f46a455 Compare April 21, 2019 02:20
@domyen domyen mentioned this pull request Apr 23, 2019
Closed
ndelangen
ndelangen approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider my comment above, if you think it's worth it to encapsulate the adding of classnames.

@ndelangen
Copy link
Member

Looks like the CI doesn't like the branchname, but all else looks ok:
https://circleci.com/gh/storybooks/storybook/119943

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #6571 into next will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #6571      +/-   ##
=========================================
+ Coverage   40.1%   40.11%   +0.01%     
=========================================
  Files        633      633              
  Lines       8660     8662       +2     
  Branches     619      619              
=========================================
+ Hits        3473     3475       +2     
  Misses      5098     5098              
  Partials      89       89
Impacted Files Coverage Δ
lib/ui/src/components/sidebar/SidebarItem.js 96% <ø> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarStories.js 100% <100%> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.88% <100%> (ø) ⬆️
lib/ui/src/components/sidebar/Sidebar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74582af...f46a455. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #6571 into next will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #6571      +/-   ##
=========================================
+ Coverage   40.1%   40.11%   +0.01%     
=========================================
  Files        633      633              
  Lines       8660     8662       +2     
  Branches     619      619              
=========================================
+ Hits        3473     3475       +2     
  Misses      5098     5098              
  Partials      89       89
Impacted Files Coverage Δ
lib/ui/src/components/sidebar/SidebarItem.js 96% <ø> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarStories.js 100% <100%> (ø) ⬆️
lib/ui/src/components/sidebar/SidebarHeading.js 88.88% <100%> (ø) ⬆️
lib/ui/src/components/sidebar/Sidebar.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74582af...f46a455. Read the comment docs.

@mbellary-chwy mbellary-chwy merged commit bbc3932 into next Apr 23, 2019
@mbellary-chwy mbellary-chwy deleted the feature/add-classNames-to-stories-nav-elements branch April 23, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@domyen domyen Awaiting requested review from domyen

@shilman shilman Awaiting requested review from shilman

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@danielduan danielduan Awaiting requested review from danielduan

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@mbellary-chwy mbellary-chwy

Labels
feature request ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbellary-chwy @ndelangen