Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-native: Fix backgrounds addon #6393

Merged
merged 6 commits into from
Apr 4, 2019

Conversation

benoitdion
Copy link
Member

@benoitdion benoitdion commented Apr 3, 2019

Get 'backgrounds' from the story parameters instead of the channel to match the web api.

storybook react-native currently doesn't have theming/global value override so we still need the withBackgrounds decorator.

Get 'backgrounds' from the story parameters instead of the channel to match the web api.

storybook react-native currently doesn't have theming/global value override so we still need the `withBackgrounds` decorator.

TODO: update readme
@vercel
Copy link

vercel bot commented Apr 3, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-react-native-fix-backgro.storybook.now.sh

@shilman shilman changed the title Fix backgrounds addon React-native: Fix backgrounds addon Apr 3, 2019
@shilman shilman added this to the 5.1.0 milestone Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #6393 into next will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6393      +/-   ##
==========================================
+ Coverage   38.31%   38.38%   +0.06%     
==========================================
  Files         649      649              
  Lines        9857     9840      -17     
  Branches      388      388              
==========================================
  Hits         3777     3777              
+ Misses       6020     6003      -17     
  Partials       60       60
Impacted Files Coverage Δ
addons/ondevice-backgrounds/src/constants.js 0% <ø> (ø) ⬆️
.../src/preview/components/OnDeviceUI/addons/index.js 0% <ø> (ø) ⬆️
addons/ondevice-backgrounds/src/container.js 0% <0%> (ø) ⬆️
addons/ondevice-backgrounds/src/BackgroundPanel.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/index.js 0% <0%> (ø) ⬆️
lib/client-api/src/client_api.js 78.64% <0%> (-0.78%) ⬇️
lib/ui/src/settings/about.js 92.59% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c78ccc...bc19777. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #6393 into next will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6393      +/-   ##
==========================================
+ Coverage   38.31%   38.38%   +0.06%     
==========================================
  Files         649      649              
  Lines        9857     9840      -17     
  Branches      388      388              
==========================================
  Hits         3777     3777              
+ Misses       6020     6003      -17     
  Partials       60       60
Impacted Files Coverage Δ
.../src/preview/components/OnDeviceUI/addons/index.js 0% <ø> (ø) ⬆️
lib/core/src/server/common/babel.js 0% <ø> (ø) ⬆️
addons/ondevice-backgrounds/src/constants.js 0% <ø> (ø) ⬆️
app/react-native/src/preview/index.js 0% <0%> (ø) ⬆️
addons/ondevice-backgrounds/src/container.js 0% <0%> (ø) ⬆️
addons/ondevice-backgrounds/src/BackgroundPanel.js 0% <0%> (ø) ⬆️
lib/client-api/src/client_api.js 78.64% <0%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c78ccc...ed2e360. Read the comment docs.

@vercel vercel bot temporarily deployed to staging April 3, 2019 12:52 Inactive
@benoitdion benoitdion merged commit db7c174 into next Apr 4, 2019
@benoitdion benoitdion deleted the react-native/fix-backgrounds-addon branch April 4, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants