-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-native: Fix backgrounds addon #6393
Conversation
Get 'backgrounds' from the story parameters instead of the channel to match the web api. storybook react-native currently doesn't have theming/global value override so we still need the `withBackgrounds` decorator. TODO: update readme
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-react-native-fix-backgro.storybook.now.sh |
Codecov Report
@@ Coverage Diff @@
## next #6393 +/- ##
==========================================
+ Coverage 38.31% 38.38% +0.06%
==========================================
Files 649 649
Lines 9857 9840 -17
Branches 388 388
==========================================
Hits 3777 3777
+ Misses 6020 6003 -17
Partials 60 60
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #6393 +/- ##
==========================================
+ Coverage 38.31% 38.38% +0.06%
==========================================
Files 649 649
Lines 9857 9840 -17
Branches 388 388
==========================================
Hits 3777 3777
+ Misses 6020 6003 -17
Partials 60 60
Continue to review full report at Codecov.
|
Get 'backgrounds' from the story parameters instead of the channel to match the web api.
storybook react-native currently doesn't have theming/global value override so we still need the
withBackgrounds
decorator.