Support OnPush change detection for class-specified components (to allow use of knobs) #6360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6359
What I did
In AppComponent,
componentRef.injector.get(ChangeDetectorRef)
), rather than the one available as a property on the component ref object (componentRef.changeDetectorRef
), as the latter does not work.childChangeDetectorRef.markForCheck()
), but I call change detection from the AppComponent itself (this.changeDetectorRef.detectChanges()
) to ensure that any properties using @HostBinding are also updated.How to test
I don't think so, unless we there is an easy way to produce screenshots after knob interaction.
Yes, included in this PR.
No.