Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs: Rename ALL panel to Other for ungrouped knobs #6232

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 22, 2019

Issue: #5256

What I did

  • Update the title of the tab for ungrouped knobs to better reflect its function
  • Always sort the Other tab last
  • Added an example to official storybook
  • Update tests and snapshots

How to test

See the knobs "tweaks static values organized in groups" in official-storybook

@shilman shilman added bug addon: knobs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 22, 2019
@shilman shilman added this to the 5.0.x milestone Mar 22, 2019
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #6232 into next will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6232      +/-   ##
==========================================
+ Coverage   38.13%   38.14%   +<.01%     
==========================================
  Files         645      645              
  Lines        9644     9645       +1     
  Branches      355      355              
==========================================
+ Hits         3678     3679       +1     
  Misses       5911     5911              
  Partials       55       55
Impacted Files Coverage Δ
addons/ondevice-knobs/src/panel.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/Panel.js 80% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fef99...3d8b8bc. Read the comment docs.

@mkochendorfer
Copy link

This is a great change. Any chance you can also update Other to always be the last tab @shilman. I noticed this with All before where sometimes it would end up buried in the middle of other tabs if you had group names that came before All alphabetically. Same would be true here for Other.

@shilman
Copy link
Member Author

shilman commented Mar 23, 2019

Good call @mkochendorfer. Done!

@ndelangen ndelangen merged commit 313c84e into next Mar 25, 2019
@ndelangen ndelangen deleted the 5256-fix-ungrouped-knobs branch March 25, 2019 22:14
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 26, 2019
shilman pushed a commit that referenced this pull request Mar 26, 2019
Knobs: Rename ALL panel to Other for ungrouped knobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants