fix(client-api): add core-js as a dep #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client-api requires core-js in the dist files but it is not listed as a dependency. This causes it to use whatever package npm/yarn/whatev thinks it should use, in my case, ver3 since that's the top most version.
Codecov Report
@@ Coverage Diff @@
## next #6209 +/- ##
=======================================
Coverage 38.13% 38.13%
=======================================
Files 645 645
Lines 9644 9644
Branches 355 355
=======================================
Hits 3678 3678
Misses 5911 5911
Partials 55 55Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## next #6209 +/- ##
=======================================
Coverage 38.13% 38.13%
=======================================
Files 645 645
Lines 9644 9644
Branches 355 355
=======================================
Hits 3678 3678
Misses 5911 5911
Partials 55 55Continue to review full report at Codecov.
|
ndelangen
approved these changes
Mar 21, 2019
|
Thank you @eddiemonge |
shilman
added
patch:yes
shilman
pushed a commit
that referenced
this pull request
Mar 23, 2019
fix(client-api): add core-js as a dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-api requires core-js in the dist files but it is not listed as a dependency. This causes it to use whatever package npm/yarn/whatev thinks it should use, in my case, ver3 since that's the top most version.
See #6204 (comment) for more info on the problem