Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fonts and color to styling in info addon #6186

Conversation

SteffenGorenflo
Copy link
Contributor

Issue: #5723

What I did

Add font family and color to the styling of the info addon.

c7f624e#diff-36f288162c3cc9bd518d680f366bbe54 removed the font with the color and #5759 added the font again, but not with the color and at the (imho) wrong place.

I think with my solution the info addon has the correct fonts and color when rendering "behind" the story as well as inline.

How to test

When rendering the Story Button with new info in the cra-kitchen-sink example, add info: { inline: true } to the options. The rendered font of the addon-info should look the same as if the addon was rendered with info: { inline: false}

  • Is this testable with Jest or Chromatic screenshots?
    Yes
  • Does this need a new example in the kitchen sink apps?
    Maybe we can render a story with the inline options to true
  • Does this need an update to the documentation?
    No

If your answer is yes to any of these, please make sure to include it in your PR.

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #6186 into next will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            next    #6186      +/-   ##
=========================================
+ Coverage   37.9%   37.93%   +0.03%     
=========================================
  Files        645      645              
  Lines       9642     9626      -16     
  Branches     354      352       -2     
=========================================
- Hits        3655     3652       -3     
+ Misses      5940     5927      -13     
  Partials      47       47
Impacted Files Coverage Δ
addons/info/src/components/Story.js 88.34% <ø> (ø) ⬆️
app/angular/src/client/preview/angular/helpers.ts 38.63% <0%> (-0.14%) ⬇️
addons/knobs/src/registerKnobs.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/index.js 0% <0%> (ø) ⬆️
app/react-native/src/index.js 0% <0%> (ø) ⬆️
...client/preview/angular/components/app.component.ts 27.02% <0%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a4018...138ef71. Read the comment docs.

@ndelangen
Copy link
Member

@SteffenGorenflo 👍

@ndelangen ndelangen merged commit e438af1 into storybookjs:next Mar 21, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 22, 2019
@shilman shilman added this to the 5.0.x milestone Mar 22, 2019
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 23, 2019
shilman pushed a commit that referenced this pull request Mar 23, 2019
…-inherit-styling

Add fonts and color to styling in info addon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants