Add fonts and color to styling in info addon #6186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5723
What I did
Add font family and color to the styling of the info addon.
c7f624e#diff-36f288162c3cc9bd518d680f366bbe54 removed the font with the color and #5759 added the font again, but not with the color and at the (imho) wrong place.
I think with my solution the info addon has the correct fonts and color when rendering "behind" the story as well as inline.
How to test
When rendering the Story
Button with new info
in the cra-kitchen-sink example, addinfo: { inline: true }
to the options. The rendered font of the addon-info should look the same as if the addon was rendered withinfo: { inline: false}
Yes
Maybe we can render a story with the inline options to true
No
If your answer is yes to any of these, please make sure to include it in your PR.