Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add the raw method to the react-native implementation #6182

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

rmevans9
Copy link
Contributor

Issue: The new client for react-native did not export the raw method from clientApi as the storyshots addon was expecting

What I did

Added the raw method as an export from the react-native client

How to test

  • Run the storyshots addon with the latest alpha version of storybook on a react-native project

@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #6182 into next will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #6182     +/-   ##
=========================================
+ Coverage   37.93%   38.04%   +0.1%     
=========================================
  Files         645      643      -2     
  Lines        9626     9421    -205     
  Branches      352     1344    +992     
=========================================
- Hits         3652     3584     -68     
+ Misses       5927     5269    -658     
- Partials       47      568    +521
Impacted Files Coverage Δ
app/react-native/src/preview/index.js 0% <ø> (ø) ⬆️
app/react-native/src/index.js 0% <0%> (ø) ⬆️
lib/ui/src/settings/shortcuts_page.js 0% <0%> (-25%) ⬇️
lib/ui/src/containers/panel.js 14.28% <0%> (-19.05%) ⬇️
lib/ui/src/containers/nav.js 11.76% <0%> (-4.91%) ⬇️
addons/notes/src/Panel.tsx 39.62% <0%> (-4.28%) ⬇️
app/polymer/src/client/index.js 0% <0%> (ø) ⬆️
app/html/standalone.js 0% <0%> (ø) ⬆️
lib/core/src/server/config.js 0% <0%> (ø) ⬆️
lib/core/src/server/cli/prod.js 0% <0%> (ø) ⬆️
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b8243...dc93f0b. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @rmevans9!!!

@shilman shilman added this to the v5.1.0 milestone Mar 19, 2019
@shilman shilman merged commit 81b1e30 into next Mar 19, 2019
@shilman shilman deleted the fix/react-native-storyshots-fix branch March 19, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants