-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brandImage to occupy 100% of the width of <BrandArea/> #5904
brandImage to occupy 100% of the width of <BrandArea/> #5904
Conversation
@maraisr thanks for this PR, I want to merge it, but some snapshots need to be updated, would you be able to update them? |
@ndelangen those snapahots have been updated! Thank you! |
Codecov Report
@@ Coverage Diff @@
## next #5904 +/- ##
==========================================
- Coverage 38.04% 34.93% -3.12%
==========================================
Files 643 648 +5
Lines 9420 9515 +95
Branches 1373 1380 +7
==========================================
- Hits 3584 3324 -260
- Misses 5268 5574 +306
- Partials 568 617 +49
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #5904 +/- ##
=======================================
Coverage 38.04% 38.04%
=======================================
Files 643 643
Lines 9420 9420
Branches 1373 1373
=======================================
Hits 3584 3584
Misses 5268 5268
Partials 568 568
Continue to review full report at Codecov.
|
That force push there, was just a rebase onto upstream/next. |
Issue: #6151
If you go:
The
<Img/>
has no width or height, nor does<Brand/>
or<BrandArea/>
. As they're all threedisplay: block
, we can safely tell it to occupy 100% the height, and 100% the width of their parents. Because they do,<Img/>
will stretch 100% of the height of<Head/>
, and width auto.Tested this with your own logo: https://storybook.js.org/images/logos/logo-storybook.svg, rather than use
<Logo/>
.