Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SidebarItem feels "laggy" when clicked #5850

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Fix: SidebarItem feels "laggy" when clicked #5850

merged 2 commits into from
Mar 5, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented Mar 4, 2019

Issue:
SidebarItem feels laggy when clicked. Reported by @Hypnosphi in Discord
image

What I did

  • Eliminate transition 75ms css transition

How to test

  • Click a story in the Sidebar. It should now visually change state instantly.

@domyen domyen added this to the v5.0.0 milestone Mar 4, 2019
@domyen domyen requested a review from Hypnosphi March 4, 2019 19:41
@vercel
Copy link

vercel bot commented Mar 4, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@ndelangen ndelangen self-assigned this Mar 4, 2019
@Hypnosphi
Copy link
Member

Please update storyshots: yarn test --core --update

@vercel vercel bot requested a deployment to staging March 4, 2019 21:14 Abandoned
@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #5850 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #5850   +/-   ##
=====================================
  Coverage   34.3%   34.3%           
=====================================
  Files        648     648           
  Lines       9465    9465           
  Branches    1344    1344           
=====================================
  Hits        3247    3247           
  Misses      5600    5600           
  Partials     618     618
Impacted Files Coverage Δ
lib/ui/src/components/sidebar/SidebarItem.js 96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15312c1...000b483. Read the comment docs.

@tmeasday tmeasday merged commit a28c595 into next Mar 5, 2019
@tmeasday tmeasday deleted the laggy-sidebaritem-active branch March 5, 2019 00:32
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 5, 2019
shilman pushed a commit that referenced this pull request Mar 5, 2019
@shilman
Merge pull request #5850 from storybooks/laggy-sidebaritem-active
f9343ee 
Fix: SidebarItem feels "laggy" when clicked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hypnosphi Hypnosphi Hypnosphi approved these changes

@ndelangen ndelangen ndelangen approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

@danielduan danielduan Awaiting requested review from danielduan

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@domyen @Hypnosphi @ndelangen @tmeasday @shilman