Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX bad mockdata #5741

Merged
merged 1 commit into from
Feb 25, 2019
Merged

FIX bad mockdata #5741

merged 1 commit into from
Feb 25, 2019

Conversation

ndelangen
Copy link
Member

Pretty self explanatory

@ndelangen ndelangen added this to the v5.0.0 milestone Feb 25, 2019
@ndelangen ndelangen self-assigned this Feb 25, 2019
@ndelangen ndelangen requested a review from shilman February 25, 2019 00:17
@codecov
Copy link

codecov bot commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #5741 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5741   +/-   ##
=======================================
  Coverage   33.31%   33.31%           
=======================================
  Files         648      648           
  Lines        9372     9372           
  Branches     1356     1356           
=======================================
  Hits         3122     3122           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
...c/components/sidebar/treeview/treeview.mockdata.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d1728...fc62e9c. Read the comment docs.

@ndelangen ndelangen merged commit fe22e17 into next Feb 25, 2019
@ndelangen ndelangen deleted the fix/bad-mockdata branch February 25, 2019 01:04
@codecov
Copy link

codecov bot commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #5741 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5741   +/-   ##
=======================================
  Coverage   33.31%   33.31%           
=======================================
  Files         648      648           
  Lines        9372     9372           
  Branches     1356     1356           
=======================================
  Hits         3122     3122           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
...c/components/sidebar/treeview/treeview.mockdata.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d1728...fc62e9c. Read the comment docs.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 25, 2019
shilman pushed a commit that referenced this pull request Feb 25, 2019
@ndelangen @shilman
Merge pull request #5741 from storybooks/fix/bad-mockdata
2839fac 
FIX bad mockdata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@shilman shilman Awaiting requested review from shilman

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@ndelangen ndelangen

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @tmeasday @shilman