Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTORE the eject button #5737

Merged
merged 2 commits into from
Feb 24, 2019
Merged

RESTORE the eject button #5737

merged 2 commits into from
Feb 24, 2019

Conversation

ndelangen
Copy link
Member

Issue: the fullscreen button was in the toolbar twice, the eject button was missing

What I did

I fixed it,

Please never merge PR that do not have approved chromatic, I remember denying this change.

@ndelangen ndelangen requested review from shilman and removed request for Hypnosphi February 24, 2019 14:31
@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #5737 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5737   +/-   ##
=======================================
  Coverage   33.31%   33.31%           
=======================================
  Files         648      648           
  Lines        9372     9372           
  Branches     1356     1331   -25     
=======================================
  Hits         3122     3122           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/src/components/preview/preview.js 87.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17032f5...52cde0c. Read the comment docs.

@ndelangen ndelangen merged commit 1187e16 into next Feb 24, 2019
@ndelangen ndelangen deleted the tech/restore-eject branch February 24, 2019 15:02
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 25, 2019
shilman pushed a commit that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants