Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/theming broken #5722

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Fix/theming broken #5722

merged 5 commits into from
Feb 22, 2019

Conversation

ndelangen
Copy link
Member

Issue: #5706

What I did

I moved the aliases to the ui package

I tested this by hosting a local npm registry, publishing, updating a reproduction repo, installing, then running the repro.

It worked!

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #5722 into next will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5722      +/-   ##
==========================================
- Coverage   33.28%   33.27%   -0.01%     
==========================================
  Files         648      648              
  Lines        9371     9367       -4     
  Branches     1355     1355              
==========================================
- Hits         3119     3117       -2     
+ Misses       5637     5635       -2     
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/scripts/createDlls.js 0% <ø> (ø) ⬆️
lib/ui/paths.js 0% <ø> (ø) ⬆️
.../core/src/server/manager/manager-webpack.config.js 0% <ø> (ø) ⬆️
lib/client-logger/src/index.ts 100% <0%> (ø) ⬆️
lib/channel-postmessage/src/index.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66cc7fd...d418bc2. Read the comment docs.

@shilman shilman merged commit c3c7d6c into next Feb 22, 2019
@shilman shilman deleted the fix/theming-broken branch February 22, 2019 15:55
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2019
shilman added a commit that referenced this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants