Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor addon ux tweaks #5712

Merged
merged 3 commits into from
Feb 21, 2019
Merged

Minor addon ux tweaks #5712

merged 3 commits into from
Feb 21, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented Feb 21, 2019

Issue: These are tiny UX improvements that I found as I was fixing other bugs

What I did

  • Improve viewport readability in the tooltip by changing the format to {width}x{height} from {width}px-{height}px
  • Render a color swatch in the background addon
  • Improve consistency of the color swatches

How to test

  • Click on the background addon and see that there are swatches
  • Click on the viewport addon and see the new dimension format
  • Click on the color blindnesss addon and see that there is a subtle border around the swatch

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #5712 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5712      +/-   ##
==========================================
- Coverage   33.25%   33.24%   -0.02%     
==========================================
  Files         648      648              
  Lines        9362     9365       +3     
  Branches     1355     1330      -25     
==========================================
  Hits         3113     3113              
- Misses       5634     5637       +3     
  Partials      615      615
Impacted Files Coverage Δ
addons/viewport/src/Tool.js 0% <ø> (ø) ⬆️
addons/backgrounds/src/components/ColorIcon.tsx 0% <0%> (ø) ⬆️
addons/a11y/src/components/ColorBlindness.js 0% <0%> (ø) ⬆️
.../backgrounds/src/containers/BackgroundSelector.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedc39f...2522d5f. Read the comment docs.

@ndelangen ndelangen merged commit d986e59 into next Feb 21, 2019
@ndelangen ndelangen deleted the minor-addon-UX-tweaks branch February 21, 2019 21:14
@shilman
Copy link
Member

shilman commented Feb 22, 2019

@ndelangen This also touches those files that don't exist on release/5.0 (ColorIcon.tsx and BackgroundSelector.tsx)

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 23, 2019
shilman pushed a commit that referenced this pull request Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants