Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Clean up debug logging #5705

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Core: Clean up debug logging #5705

merged 1 commit into from
Feb 22, 2019

Conversation

ndelangen
Copy link
Member

Issue:

  • There was a debugger statement left in the postmessage-channel
  • The console is noisy because of logging all messages over the channel

What I did

REMOVE debugger statement
CHANGE log statement in channel to use logger.debug
ADD info & debug method to logger

…ogger.debug && ADD info & debug method to logger
@ndelangen ndelangen added this to the v5.0.0 milestone Feb 21, 2019
@ndelangen ndelangen self-assigned this Feb 21, 2019
@shilman shilman changed the title REMOVE debugger statement && CHANGE log statement in channel to use logger.debug && ADD info & debug method to logger Core: Clean up debug logging Feb 22, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #5705 into next will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5705      +/-   ##
==========================================
+ Coverage   33.24%   33.26%   +0.01%     
==========================================
  Files         648      648              
  Lines        9363     9365       +2     
  Branches     1330     1355      +25     
==========================================
+ Hits         3113     3115       +2     
  Misses       5635     5635              
  Partials      615      615
Impacted Files Coverage Δ
lib/channel-postmessage/src/index.ts 0% <0%> (ø) ⬆️
lib/client-logger/src/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81afc43...0537de2. Read the comment docs.

@shilman shilman merged commit 66cc7fd into next Feb 22, 2019
@shilman shilman deleted the fix/debugger-in-code branch February 22, 2019 06:37
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 22, 2019
shilman added a commit that referenced this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants