ADD a timeout around the / search hotkey, so it doesn't type into the input

[ndelangen]

Issue: #5419

• If you click anywhere in the Sidebar and press "/", you'll insert a '/' in the search box. This should not happen.

What I did

I added a 16ms timeout before giving the input-element focus.

I know it may not be the cleanest solution, but in order to cancel the event, I'd need access TO the event, and that would require more refactoring then I'm comfortable doing at this stage of the release.

[tmeasday]

Why does it need to be 16ms? Is 0 not enough?

[ndelangen]

I expected the question, @tmeasday I just pick 16ms, as that over the years seems to be the magic number that seemed to always work in stupid cases like this.

It's roughly 1 animation frame.

I could do requestAnimationFrame instead, but was like 🤷‍♀️

[codecov]

Codecov Report

Merging #5702 into next will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             next    #5702      +/-   ##
==========================================
- Coverage   33.24%   33.24%   -0.01%     
==========================================
  Files         648      648              
  Lines        9363     9364       +1     
  Branches     1330     1355      +25     
==========================================
  Hits         3113     3113              
- Misses       5635     5636       +1     
  Partials      615      615

Impacted Files	Coverage Δ
lib/ui/src/core/shortcuts.js	18.81% <0%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81afc43...9ab127f. Read the comment docs.

[tmeasday]

@ndelangen I guess I ask because I would have guessed 0 would be enough--just need to get the focus behind the event handling, which happens synchronously

[ndelangen]

@tmeasday I changed it

[shilman]

Great!