Decouple react native release #5626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/5.0 #5626 +/- ##
============================================
Coverage 32.85% 32.85%
============================================
Files 638 638
Lines 9241 9241
Branches 1314 1314
============================================
Hits 3036 3036
Misses 5565 5565
Partials 640 640Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR excludes
@storybook/react-nativeand@storybook/react-native-serverfrom the 5.0 release process. RN is not ready for a 5.0 release despite heroic efforts from the team.After it's merged, I will release
5.0.0-rc.0and announce the RC to get testing feedback so we can release 5.0 and get out of this painful limbo state.So what happens to RN?
RN development
This PR targets the
release/5.0branch, so in terms of RN development onnext, nothing will change. There is a branch https://github.com/storybooks/storybook/tree/react-native/use-core-for-server where a bunch of us are trying to migrate RN server to use Storybook core. Contributions are welcome there: please comment here if you'd like to help maintain Storybook for RN or jump onto our Discord https://discord.gg/qhAxMgNRN release
I will release Storybook for RN as soon as it's ready and tested, provided that it does not add instability to the 5.0 release process. Most likely I'll release it as part of the Storybook 5.1 release, possibly expediting that to get RN up to date ASAP.
How to test