-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpile safe-eval package #5498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI tests are throwing an error:
Do you know a fix? |
Will investigate on the weekend |
Codecov Report
@@ Coverage Diff @@
## next #5498 +/- ##
==========================================
- Coverage 31.44% 31.37% -0.07%
==========================================
Files 635 635
Lines 9173 9191 +18
Branches 1270 1271 +1
==========================================
Hits 2884 2884
- Misses 5650 5667 +17
- Partials 639 640 +1
Continue to review full report at Codecov.
|
@ndelangen fixed |
ndelangen
approved these changes
Feb 9, 2019
👏 |
shilman
added
release
patch:done
Patch/release PRs already cherry-picked to main/release branch
labels
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5472