Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve about/shortcuts stories by passing in onClose as a prop. #5425

Merged
merged 3 commits into from
Jan 31, 2019

Conversation

tmeasday
Copy link
Member

Issue: as discussed in this comment:
07df8ba#r32112836

What I did

Re-purified about and settings screen components

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Jan 31, 2019
@tmeasday tmeasday added this to the v5.0.0 milestone Jan 31, 2019
@tmeasday tmeasday added the ui label Jan 31, 2019
tmeasday referenced this pull request Jan 31, 2019
We might want to use react-hotkeys more
@ndelangen ndelangen self-assigned this Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #5425 into next will not change coverage.
The diff coverage is 63.63%.

Impacted file tree graph

@@          Coverage Diff          @@
##            next   #5425   +/-   ##
=====================================
  Coverage   31.2%   31.2%           
=====================================
  Files        625     625           
  Lines       9187    9187           
  Branches    1281    1281           
=====================================
  Hits        2867    2867           
  Misses      5680    5680           
  Partials     640     640
Impacted Files Coverage Δ
lib/ui/src/settings/shortcuts_page.js 0% <0%> (ø) ⬆️
lib/ui/src/settings/about_page.js 12.5% <0%> (-1.79%) ⬇️
lib/ui/src/settings/shortcuts.stories.js 100% <100%> (ø) ⬆️
lib/ui/src/settings/about.stories.js 100% <100%> (ø) ⬆️
lib/ui/src/settings/shortcuts.js 92.3% <50%> (+1.74%) ⬆️
lib/ui/src/settings/about.js 75% <50%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10bcdac...42cc643. Read the comment docs.

@tmeasday tmeasday merged commit f939d29 into next Jan 31, 2019
@tmeasday tmeasday deleted the tech/about-screen-fixes branch January 31, 2019 23:31
@domyen domyen mentioned this pull request Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants