Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX the layout issue where panels still sort-of appear on non story viewmodes #5413

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

ndelangen
Copy link
Member

Desktop layout had panels still semi-showing when in info viewmode

@ndelangen ndelangen added this to the v5.0.0 milestone Jan 30, 2019
@ndelangen ndelangen self-assigned this Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #5413 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5413   +/-   ##
=======================================
  Coverage   30.54%   30.54%           
=======================================
  Files         621      621           
  Lines        8939     8939           
  Branches     1248     1229   -19     
=======================================
  Hits         2730     2730           
  Misses       5566     5566           
  Partials      643      643
Impacted Files Coverage Δ
lib/ui/src/components/layout/container.js 20.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4521c...370b011. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday tmeasday merged commit ba595e4 into next Jan 31, 2019
@tmeasday tmeasday deleted the fix/layout-panel branch January 31, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants