Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addon cssresources to TS #5380

Merged
merged 4 commits into from
Jan 27, 2019
Merged

Migrate addon cssresources to TS #5380

merged 4 commits into from
Jan 27, 2019

Conversation

gaetanmaisse
Copy link
Member

Issue:

#5030

What I did

  • Migrated @storybook/addon-addon-cssresources to TypeScript
  • Refactor some class and import/export
  • Fix README (an attribute name was wrong: name -> id)

Create `CssResource` interface and use it in `CssSourcePanel`.

Also update README because some commits ago, `name` attribute used in cssresources conf has been renamed to `id`
@shilman shilman added maintenance User-facing maintenance tasks typescript labels Jan 27, 2019
@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #5380 into next will increase coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next    #5380     +/-   ##
=========================================
+ Coverage   30.37%   30.48%   +0.1%     
=========================================
  Files         622      620      -2     
  Lines        8957     8927     -30     
  Branches     1229     1245     +16     
=========================================
  Hits         2721     2721             
+ Misses       5579     5561     -18     
+ Partials      657      645     -12
Impacted Files Coverage Δ
addons/cssresources/src/index.ts 0% <0%> (ø)
addons/cssresources/src/register.tsx 0% <0%> (ø)
addons/cssresources/src/constants.ts 0% <0%> (ø)
lib/theming/src/themes/dark-syntax.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7517f2d...53a7fb5. Read the comment docs.

@ndelangen ndelangen merged commit 6f4cf1c into storybookjs:next Jan 27, 2019
@gaetanmaisse gaetanmaisse deleted the ts-migration/addon-cssresources branch January 28, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants