fix: Add missing peer dependencies to addon-knobs #4928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Uncaught TypeError: Object(...) is not a function
when using@storybook/addon-knobs
and@emotion/core@^10.x
Issue:
The combination of the above packages created the following dependency tree:
However
@emotion/styled
has a peer dependency to@emotion/[email protected]
. I didn't find any method in npm or yarn to add@emotion/[email protected]
while still being able to use@emotion/[email protected]
. This is probably the reason missing peer dependencies should be added immediately instead of relying on consuming packages to do this.What I did
@emotion/[email protected]
to dependencies of@storybook/addon-knobs
.How to test
No
No
No
If your answer is yes to any of these, please make sure to include it in your PR.