Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate manager and preview part.2 #4789

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Conversation

ndelangen
Copy link
Member

CHANGE build & dev-serve so both webpack compilation happen in the same process
CHANGE dev-serve so it watches manager

Ease of development on storybook has taken a hit, this changes the manager build back into the single (main) serve/build process.

On dev the manager build is now in watch mode.

…me process

CHANGE dev-serve so it watches manager
@ndelangen ndelangen added maintenance User-facing maintenance tasks cleanup Minor cleanup style change that won't show up in release changelog labels Nov 14, 2018
@ndelangen ndelangen added this to the next milestone Nov 14, 2018
@ndelangen ndelangen self-assigned this Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #4789 into next will increase coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #4789      +/-   ##
==========================================
+ Coverage   35.47%   35.55%   +0.08%     
==========================================
  Files         561      560       -1     
  Lines        6825     6809      -16     
  Branches      911      910       -1     
==========================================
  Hits         2421     2421              
+ Misses       3928     3913      -15     
+ Partials      476      475       -1
Impacted Files Coverage Δ
lib/core/src/server/build-static.js 0% <0%> (ø) ⬆️
lib/core/src/server/dev-server.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b393e...a92ddc5. Read the comment docs.

@ndelangen ndelangen merged commit 3be104f into next Nov 15, 2018
@ndelangen ndelangen deleted the core/separate-manager-preview-p2 branch November 15, 2018 08:03
@Hypnosphi Hypnosphi restored the core/separate-manager-preview-p2 branch December 24, 2018 13:52
@ndelangen ndelangen deleted the core/separate-manager-preview-p2 branch May 7, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant