Addon-info: Improve accessibility by contrast #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hipstersmoothie
requested review from
dangreenisrael,
danielduan,
Hypnosphi,
theinterned,
usulpro and
z4o4z
as code owners
Hypnosphi
approved these changes
Nov 2, 2018
|
Please run UPD: nevermind, as I see it's a PR created from UI, so I'll do it myself |
|
@Hypnosphi is there anything else you want me to do for thiis PR? |
|
No thanks |
Codecov Report
@@ Coverage Diff @@
## master #4698 +/- ##
=======================================
Coverage 35.59% 35.59%
=======================================
Files 557 557
Lines 6732 6732
Branches 884 884
=======================================
Hits 2396 2396
Misses 3876 3876
Partials 460 460
Continue to review full report at Codecov.
|
shilman
changed the title
shilman
changed the title
This was referenced Dec 1, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4224
What I did
Change the font color to be accessible
How to test
Is this testable with Jest or Chromatic screenshots? Yes
Does this need a new example in the kitchen sink apps? No
Does this need an update to the documentation? No
If your answer is yes to any of these, please make sure to include it in your PR.
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]