issue #4174 : support the tagConstructor option #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
approved these changes
Oct 2, 2018
| @@ -49,7 +50,13 @@ function renderStringified({ | |||
| eval(getRidOfRiotNoise(`${compiled}`)); // eslint-disable-line no-eval | |||
| }); | |||
| const sourceCode = `<root>${template}</root>`; | |||
| if (template !== '<root/>') eval(getRidOfRiotNoise(`${compiler.compile(sourceCode, {})}`)); // eslint-disable-line no-eval | |||
| const compiledRootSource = !tagConstructor | |||
There was a problem hiding this comment.
Can you please extract this to a separate function? I think riot rendering in storybook is kinda complicated (comparing to other apps), so having it as clear and granular as possible will be helpful =)
There was a problem hiding this comment.
okay. This evening after my workday.
There was a problem hiding this comment.
refactored (code moved but not changed)
libetl
force-pushed
the
feature/riot-use-constructor-in-stories-js
branch
from
c24d992 to
73ea7bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #4258 +/- ##
==========================================
+ Coverage 40.61% 40.62% +0.01%
==========================================
Files 495 495
Lines 5875 5876 +1
Branches 784 785 +1
==========================================
+ Hits 2386 2387 +1
Misses 3111 3111
Partials 378 378
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
added the support for configuring a specific tagConstuctor in a story
See #4174
How to test
Is this testable with Jest or Chromatic screenshots? yes
Does this need a new example in the kitchen sink apps? yes
Does this need an update to the documentation? no
If your answer is yes to any of these, please make sure to include it in your PR.