-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken colorpicker for knobs #4222
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #4222 +/- ##
==========================================
- Coverage 40.79% 40.78% -0.01%
==========================================
Files 493 493
Lines 5851 5852 +1
Branches 782 783 +1
==========================================
Hits 2387 2387
Misses 3088 3088
- Partials 376 377 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, at least it works now. Any idea if we could get rid of the new warning as well?
@Keraito I didn't find that issue... It might be inside that colorpicker library... :( |
@Keraito I found the issue inside the |
Can we release this one? I'm using this for theming and is totally broken right now. |
Right now this error triggers when trying to open colorpicker but with this fix it least works but we get a warning.
Current issue
After this fix issue