Cli gestorybook fix #4213
Merged
Cli gestorybook fix #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keraito
requested review from
Hypnosphi,
ndelangen and
stijnkoopal
as code owners
Generated by 🚫 dangerJS |
ndelangen
approved these changes
Sep 22, 2018
pksunkara
approved these changes
Sep 24, 2018
|
cli-latest-cra is failing because of recent release in cra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: part of #4212
When running
getstorybook, the process would not wait until initiating Storybook was finished which is an async function, making the process terminate early before finishing.I returned and awaited the generator, but cuz of that also need to wrap the code for
storybook initin its own block to prevent behaviour from overflowing. Getting rid of the depreciation at a later stage is basically removing theifstatement and case.@shilman could you give this a run?