Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dependency upgrades (major version bumps) #3957

Merged
merged 9 commits into from
Aug 5, 2018
Merged

Conversation

ndelangen
Copy link
Member

No description provided.

@ndelangen ndelangen requested a review from usulpro as a code owner August 4, 2018 22:37
@codecov
Copy link

codecov bot commented Aug 4, 2018

Codecov Report

Merging #3957 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   39.62%   39.66%   +0.04%     
==========================================
  Files         431      433       +2     
  Lines        5443     5445       +2     
  Branches      740      740              
==========================================
+ Hits         2157     2160       +3     
  Misses       2903     2903              
+ Partials      383      382       -1
Impacted Files Coverage Δ
lib/components/src/index.js 100% <ø> (ø) ⬆️
...ents/stories_panel/stories_tree/tree_decorators.js 100% <ø> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
lib/components/src/icons/chevronRight.js 0% <0%> (ø)
lib/components/src/icons/index.js 100% <100%> (ø)
lib/components/src/layout/desktop.js 73.21% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b36a7...ace51e4. Read the comment docs.

@ndelangen
Copy link
Member Author

Need some tweaks on the icon replacement
(see chromatic)

Need to fix some angular error in unit test:

 FAIL  examples/angular-cli/angularshots.test.js
  ● Test suite failed to run

    /Users/dev/Projects/GitHub/storybook/core/examples/angular-cli/.storybook/config.js: Unexpected token, expected , (1:8)

      > 1 | [object Object]
          |         ^

@igor-dv
Copy link
Member

igor-dv commented Aug 5, 2018

Related to #2936 and #3483

Also, what is wrong with react-icons?

@ndelangen
Copy link
Member Author

ndelangen commented Aug 5, 2018

Definitely nothing is wrong with react-icons, but we were using just 1 icon from it, and that single icon is no longer in this new major release...

I will fix up the icon.

@ndelangen ndelangen merged commit ffe59c0 into master Aug 5, 2018
@ndelangen ndelangen deleted the tech/updates2 branch August 5, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants