-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-native symlink resolving and add support for flow #3306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3306 +/- ##
==========================================
- Coverage 35.69% 35.62% -0.08%
==========================================
Files 472 472
Lines 10104 10125 +21
Branches 968 965 -3
==========================================
Hits 3607 3607
- Misses 5875 5901 +26
+ Partials 622 617 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable. we're adding flow support as a default here too but that's fine by me.
@meros please fix the lint errors, I think you can ignore the global requires with a // eslint-disable-line global-require
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable. we're adding flow support as a default here too but that's fine by me.
@meros please fix the lint errors, I think you can ignore the global requires with a // eslint-disable-line global-require
Done
…On Wed, Mar 28, 2018 at 5:53 PM Daniel Duan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
looks reasonable. we're adding flow support as a default here too but
that's fine by me.
@meros <https://github.com/meros> please fix the lint errors, I think you
can ignore the global requires with a // eslint-disable-line global-require
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3306 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbfBh-NlYtIIp8eucPfcFebOrbeZMLDks5ti7HkgaJpZM4S-fp0>
.
|
Issue:
The symlink resolving for react-native does not work all the time. react-native tools moved over to a new way of resolving symlinks last year: facebook/react-native@39f83c4#diff-d939fe299a50129184bf6b4208f6d497
What I did
I moved over to the new symlink method according to the react-native PR
How to test
Run storybook on a project depending on external projects in a workspace monorepo. Make sure roots are all there (just like for react-native start) and storybook is the first root.
Is this testable with Jest or Chromatic screenshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
No
If your answer is yes to any of these, please make sure to include it in your PR.