Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all startup code into @storybook/core also #3259

Merged
merged 2 commits into from
Mar 22, 2018

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 22, 2018

I'm not sure why we didn't do this already @shilman? It seems an obvious thing to do.

It's a little unfortunate that RN is so different in this respect. Still I am happier making any changes in 2 places (core + RN) than 5+

@tmeasday tmeasday requested review from shilman and a team March 22, 2018 10:18
@tmeasday
Copy link
Member Author

PS I suspect the branch name is incorrect here. This is unlikely to be the final refactor.

@igor-dv
Copy link
Member

igor-dv commented Mar 22, 2018

Oh, I am ATM doing the same for a config part 😱.

@Hypnosphi Hypnosphi added maintenance User-facing maintenance tasks core labels Mar 22, 2018
@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

Merging #3259 into master will increase coverage by 0.59%.
The diff coverage is 57.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
+ Coverage   35.61%   36.21%   +0.59%     
==========================================
  Files         442      443       +1     
  Lines        9777     9737      -40     
  Branches      897      909      +12     
==========================================
+ Hits         3482     3526      +44     
+ Misses       5704     5638      -66     
+ Partials      591      573      -18
Impacted Files Coverage Δ
app/polymer/src/client/preview/index.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/index.js 0% <0%> (ø) ⬆️
app/vue/src/client/preview/index.js 0% <0%> (ø) ⬆️
app/angular/src/client/preview/index.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/index.js 0% <0%> (ø) ⬆️
lib/core/src/client/preview/start.js 65.67% <69.76%> (ø)
addons/info/src/components/types/Enum.js 0% <0%> (ø) ⬆️
lib/core/src/server/build-dev.js 0% <0%> (ø) ⬆️
...ns/viewport/src/manager/components/viewportInfo.js 33.33% <0%> (ø) ⬆️
lib/core/src/client/manager/index.js 0% <0%> (ø) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337412e...29373ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants