-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all startup code into @storybook/core
also
#3259
Conversation
PS I suspect the branch name is incorrect here. This is unlikely to be the final refactor. |
Oh, I am ATM doing the same for a config part 😱. |
Codecov Report
@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
+ Coverage 35.61% 36.21% +0.59%
==========================================
Files 442 443 +1
Lines 9777 9737 -40
Branches 897 909 +12
==========================================
+ Hits 3482 3526 +44
+ Misses 5704 5638 -66
+ Partials 591 573 -18
Continue to review full report at Codecov.
|
I'm not sure why we didn't do this already @shilman? It seems an obvious thing to do.
It's a little unfortunate that RN is so different in this respect. Still I am happier making any changes in 2 places (core + RN) than 5+