-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-freeze master #3149
Feature-freeze master #3149
Conversation
MAJOR: 'MAJOR', | ||
}; | ||
|
||
const branchVersion = Versions.PATCH; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable should be configured per branch. Maybe this should be a field in package.json
, I'm not sure
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
=======================================
Coverage 35.98% 35.98%
=======================================
Files 437 437
Lines 9476 9476
Branches 881 898 +17
=======================================
Hits 3410 3410
- Misses 5490 5497 +7
+ Partials 576 569 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like a good temporary thing for us to do.
Actually, for release branch it should be permanent |
This blocks merging of PRs with
BREAKING CHANGE
andfeature request
PRs