Renamed angular root node to avoid name collisions #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular CLI also uses `app-root` as the root node name and this could lead to weird bugs. Signed-off-by: Carlos Vega <[email protected]>
alterx
added
angular
patch:yes
igor-dv
approved these changes
Jan 5, 2018
ralzinov
requested changes
Jan 5, 2018
| @@ -13,6 +13,6 @@ | |||
| <%= htmlWebpackPlugin.options.data.previewHead %> | |||
| </head> | |||
| <body> | |||
| <app-root></app-root> | |||
| <storybook-dynamic-app-root></storybook-dynamic-app-roott> | |||
Codecov Report
@@ Coverage Diff @@
## master #2657 +/- ##
=======================================
Coverage 34.34% 34.34%
=======================================
Files 389 389
Lines 8750 8750
Branches 898 898
=======================================
Hits 3005 3005
Misses 5156 5156
Partials 589 589
Continue to review full report at Codecov.
|
ralzinov
approved these changes
Jan 5, 2018
Signed-off-by: Carlos Vega <[email protected]>
…orybook into renaming-angular-root-node
Signed-off-by: Carlos Vega <[email protected]>
Signed-off-by: Carlos Vega <[email protected]>
…orybook into renaming-angular-root-node
shilman
pushed a commit
that referenced
this pull request
Jan 7, 2018
Renamed angular root node to avoid name collisions
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular CLI also uses
app-rootas the root node name and this could lead to weird bugs.Issue: #2647
What I did
Renamed the angular root node. This is not directly related to the issue linked (the cause was different) but we should rename the node anyway.
How to test