-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish package sources along with transpiled files #2604
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 397 397
Lines 8855 8855
Branches 951 937 -14
=======================================
Hits 2888 2888
- Misses 5317 5327 +10
+ Partials 650 640 -10
Continue to review full report at Codecov.
|
I think we don't want to publish |
@igor-dv If you don't publish the |
What's exactly the problem with it? I find it very convenient to be able to view external packages' sources directly in |
I don't feel very expert on this but I've seen it done before and it feels OK to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow smart bundlers to tree-shake, correct?
LGTM
Well we can actually to that ourselves, by tweaking our default webpack config =) |
Publish package sources along with transpiled files
Issue: #2602
In #2589, I introduced
jsnext:main
fields so that eslint can resolve named and default exports when importing one package from another. They point to files insrc
directories that aren't published currently.