-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Angular] Change template story files extension .ts #2594
Conversation
+1 |
Codecov Report
@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
+ Coverage 32.61% 32.69% +0.08%
==========================================
Files 397 397
Lines 8855 8882 +27
Branches 941 1123 +182
==========================================
+ Hits 2888 2904 +16
+ Misses 5316 5218 -98
- Partials 651 760 +109
Continue to review full report at Codecov.
|
Make sense to me, but I'd like like to hear from people familiar with angular stuff |
LGTM, but something is wrong with |
I have updated the angular snapshots so it looks for |
I am very familiar with Angular. I can tell that 99% of developers are working with typescript. Also, the angular-cli creates your projects with typescript files. |
Thanks @ersel , I missed it 😆 |
[Angular] Change template story files extension .ts
Issue:
Angular developers prefer TypeScript to JavaScript. It's useful that
getstorybook
cmd creates.ts
stories files.What I did
.ts
.