Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Change template story files extension .ts #2594

Merged
merged 4 commits into from
Jan 2, 2018

Conversation

Quramy
Copy link
Contributor

@Quramy Quramy commented Dec 28, 2017

Issue:
Angular developers prefer TypeScript to JavaScript. It's useful that getstorybook cmd creates .ts stories files.

What I did

  • [Angular] Change template story files' extension to .ts .

@NetanelBasal
Copy link

+1

@codecov
Copy link

codecov bot commented Jan 1, 2018

Codecov Report

Merging #2594 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
+ Coverage   32.61%   32.69%   +0.08%     
==========================================
  Files         397      397              
  Lines        8855     8882      +27     
  Branches      941     1123     +182     
==========================================
+ Hits         2888     2904      +16     
+ Misses       5316     5218      -98     
- Partials      651      760     +109
Impacted Files Coverage Δ
app/vue/src/server/utils.js 44.11% <0%> (-9.46%) ⬇️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Info.js 0% <0%> (ø) ⬆️
addons/info/src/components/Story.js 88.88% <0%> (ø) ⬆️
lib/codemod/src/transforms/move-buildin-addons.js 46.87% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/withLifecycleDecorator.js 17.14% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 54.54% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6de4c6...e6e4430. Read the comment docs.

@Hypnosphi
Copy link
Member

Make sense to me, but I'd like like to hear from people familiar with angular stuff

@Hypnosphi Hypnosphi requested review from alterx and igor-dv January 1, 2018 21:57
@igor-dv
Copy link
Member

igor-dv commented Jan 1, 2018

LGTM, but something is wrong with snapshots/angular-cli. It is looking for the index.stories.js

@ersel
Copy link
Contributor

ersel commented Jan 1, 2018

I have updated the angular snapshots so it looks for .ts files.

@NetanelBasal
Copy link

I am very familiar with Angular. I can tell that 99% of developers are working with typescript. Also, the angular-cli creates your projects with typescript files.

@Quramy
Copy link
Contributor Author

Quramy commented Jan 2, 2018

I have updated the angular snapshots so it looks for .ts files.

Thanks @ersel , I missed it 😆

@Hypnosphi Hypnosphi merged commit d5a0d10 into storybookjs:master Jan 2, 2018
@Hypnosphi Hypnosphi added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 3, 2018
shilman pushed a commit that referenced this pull request Jan 7, 2018
[Angular] Change template story files extension .ts
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants