-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TableComponent
option for addon-info
#2400
Add TableComponent
option for addon-info
#2400
Conversation
Live example for reference |
This looks like a valuable feature to me. I changed the base branch for this PR to After that, you may need to run |
d89c448
to
7b8f765
Compare
7b8f765
to
0f38aad
Compare
Codecov Report
@@ Coverage Diff @@
## release/3.3 #2400 +/- ##
===============================================
+ Coverage 18.76% 18.77% +<.01%
===============================================
Files 348 349 +1
Lines 8200 8212 +12
Branches 897 900 +3
===============================================
+ Hits 1539 1542 +3
- Misses 5978 5987 +9
Partials 683 683
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since it's going into 3.3, why don't we just make that a new default to drop the required column in favor of the I also think having monospace font for the proptype value could be useful as a default as well. Technically this isn't a breaking change since the same data is still presented, although in a slightly different way. |
Issue:
What I did
I added an option
TableProp
that allows you to configure how the table is rendered foraddon-info
. You can find more details in this issue: #2397Here's a gif that shows how you could use this option to remove the
required
column and instead render an asterisk next to the prop name.How to test
Not sure :/ I manually tested inside the kitchen sink.
Is this testable with jest or storyshots?
No I don't think so
Does this need a new example in the kitchen sink apps?
Yes, it's included in the PR :)
Does this need an update to the documentation?
Yes, it's included in the PR :)
If your answer is yes to any of these, please make sure to include it in your PR.