Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong "withTests" examples + add documentation #2398

Merged
merged 2 commits into from
Nov 29, 2017

Conversation

renaudtertrais
Copy link
Contributor

Issue:

What I did

Update addon-jest/README with good examples regarding the usage of withTests + add doc

How to test

Read README

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #2398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2398   +/-   ##
=======================================
  Coverage   19.92%   19.92%           
=======================================
  Files         293      293           
  Lines        6485     6485           
  Branches      758      772   +14     
=======================================
  Hits         1292     1292           
+ Misses       4600     4574   -26     
- Partials      593      619   +26
Impacted Files Coverage Δ
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 50.47% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Elements.js 0% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 31.37% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.3% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Rules.js 0% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1995b60...cea3f08. Read the comment docs.

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was it the source of #2367?

@Hypnosphi Hypnosphi merged commit bb86e68 into master Nov 29, 2017
@Hypnosphi Hypnosphi deleted the bugfix/addon-jest-fix-wrong-examples branch November 29, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants