-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize CI workflow #2331
Optimize CI workflow #2331
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2331 +/- ##
=======================================
Coverage 21.19% 21.19%
=======================================
Files 283 283
Lines 6156 6156
Branches 724 731 +7
=======================================
Hits 1305 1305
+ Misses 4301 4299 -2
- Partials 550 552 +2
Continue to review full report at Codecov.
|
I made all the other jobs depend on before: https://circleci.com/workflow-run/c7e6c92c-90f4-4746-8b4a-d70c21cf4850 |
A further optimisation would be to move the docs and react native bootstrapping from |
After moving |
After moving The next step could be moving RN unit-tests to |
And voila — after moving react-native tests to the corresponding job both overall workflow time and total agent time is significantly less: |
build
job results to reuse them in other jobspaths: | ||
- addons | ||
- app | ||
- lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This caches app
, addons
, and lib
directories using current commit hash as a part of the cache key.
bootstrap --core
transpiles all the packages in those directories (src
to dist
).
Ideally, it should be
paths:
- addons/*/dist
- app/*/dist
- lib/*/dist
But unfortunately, wildcards are not supported in cached directories paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is soo awesome, thanks!
Issue: #2179