Add addon jest #2295

renaudtertrais · 2017-11-12T12:46:54Z

Issue:

What I did

Add addon-jest to monorepo

How to test

In storybook example

Hypnosphi · 2017-11-12T17:20:02Z

@shilman is a new addon considered a "small feature"?

Hypnosphi

yarn.lock should be removed as well: we use yarn workspaces feature, so all the dependencies are installed by root yarn bootstrap command

Hypnosphi · 2017-11-12T17:12:21Z

addons/jest/.eslintignore

@@ -0,0 +1,2 @@
+node_modules
+dist


Those should be covered by root .eslintignore file

Hypnosphi · 2017-11-12T17:13:42Z

addons/jest/.eslintrc.js

+    },
+  },
+};
+


Let's try to use our root eslint config for this package, and override only the things that really need it, if any

Hypnosphi · 2017-11-12T17:16:34Z

addons/jest/example/.storybook/config.js

+  require('../List.story');
+}
+
+configure(loadStories, module);


Let's move the stories to example/cra-kitchen-sink

I am on it.

Hypnosphi · 2017-11-12T19:08:43Z

addons/jest/package.json

+  },
+  "scripts": {
+    "prebuild": "npm run clear",
+    "build": "cross-env NODE_ENV=production babel -d ./dist ./src",


We need a prepare script instead (see other addons). All the babel-related stuff can be removed from package as we use top-level babel dependencies and setup for transpiling everything

Hypnosphi · 2017-11-13T23:20:43Z

addons/jest/package.json

    "jest": "^21.2.1",
    "react": "^16.1.0",
    "react-dom": "^16.1.0",
    "style-loader": "^0.19.0"
  },
  "peerDependencies": {
-    "@storybook/addons": "^3.2.14",
    "prop-types": "^15.6.0",


It should be a simple dependency, not a peer one

I actually meant the prop-types package. It's OK for an end user not to have it

…on-jest

codecov · 2017-11-14T06:56:37Z

Codecov Report

Merging #2295 into master will decrease coverage by 1.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #2295     +/-   ##
=========================================
- Coverage   21.23%   20.14%   -1.1%     
=========================================
  Files         283      293     +10     
  Lines        6155     6489    +334     
  Branches      727      755     +28     
=========================================
  Hits         1307     1307             
- Misses       4298     4595    +297     
- Partials      550      587     +37

Impacted Files	Coverage Δ
addons/jest/src/components/Result.js	`0% <0%> (ø)`
addons/jest/src/register.js	`0% <0%> (ø)`
addons/jest/src/hoc/provideJestResult.js	`0% <0%> (ø)`
lib/components/src/theme.js	`0% <0%> (ø)`	⬆️
addons/jest/src/components/Panel.js	`0% <0%> (ø)`
addons/jest/register.js	`0% <0%> (ø)`
addons/jest/src/index.js	`0% <0%> (ø)`
lib/components/src/index.js	`0% <0%> (ø)`	⬆️
addons/jest/src/styles.js	`0% <0%> (ø)`
addons/jest/styles.js	`0% <0%> (ø)`
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c1645...70d3424. Read the comment docs.

ndelangen · 2017-11-14T07:12:35Z

Ready to merge I think? @Hypnosphi ?

Hypnosphi · 2017-11-14T15:09:05Z

Please move prop-types to dependencies

… add-addon-jest

ndelangen · 2017-11-18T23:35:25Z

Latest screenshot:

Hypnosphi · 2017-11-18T23:45:15Z

Actually, I still don't get what's happening here =( Why those green and red bars have different length? Why storybook is a place to show test results in a fancy way? Why would anybody want to make empty stories?

Hypnosphi · 2017-11-19T00:09:07Z

addons/jest/README.md

+```
+
+**Known issue**: if you use a deploy script using for example `gh-pages`, be sure to not put
+the `test` script that write the result in part of the script process (in `predeploy` for example).


Hypnosphi · 2017-11-19T00:10:07Z

addons/jest/README.md

+
+Brings Jest results in storybook.
+
+[![Storybook Jest Addon Demo](@storybook/addon-jest.gif)](https://@storybook/addon-jest-example.herokuapp.com/)


The link is broken

shilman

What's up with the SimpleList CI failures? Looks like some files didn't get checked in?

Aside from that, this looks great. @Hypnosphi this is a new feature so technically it should probably go into 3.3, but it's isolated and shouldn't break anything so I'm also OK with it to go into a patch.

Very excited to get this into peoples' hands in one way or another and look forward to getting a cleaned up version merged soon after the changes have been addressed.

Hypnosphi · 2017-11-19T22:17:15Z

it's isolated and shouldn't break anything

Actually isolation is an issue here. Once someone adds this addon for some of the stories, nobody can start-storybook in that project without running those tests locally first.

Hypnosphi · 2017-11-19T22:24:33Z

addons/jest/README.md

+}
+```
+
+Add it the result file to `.gitignore`:


@renaudtertrais @ndelangen why do we even have this recommendation? Checking this file into VCS makes a lot of sense to me, given that it's used in an import. What's the downside?

Well, it will likely have tons of merge-conflicts over time?

Just like lockfiles and test snapshots. It's easy to regenerate them, so this shouldn't be a problem

true

I will change the text and make it so users are aware of the trade-offs.

ndelangen · 2017-11-23T07:21:39Z

@shilman, @Hypnosphi I think I've resolved all issues? Can you accept?

ndelangen · 2017-11-23T21:40:22Z

@shilman The thing you mentioned has been resolved, I hope you're OK with me merging this.

renaudtertrais and others added 4 commits November 11, 2017 15:48

initial commit

f6df222

v0.0.1

1db27cb

Add new TODOS item + add know issue when deploying in README

b1db164

RENAME package & SYNC version with monorepo

1433160

Hypnosphi requested changes Nov 12, 2017

View reviewed changes

danielduan and others added 2 commits November 12, 2017 13:36

Merge branch 'master' into add-addon-jest

812c054

Remove eslint files and yarn.lock

f1f869c

Hypnosphi requested changes Nov 12, 2017

View reviewed changes

ndelangen added 2 commits November 14, 2017 00:17

Merge branch 'master' into add-addon-jest

e66e375

REMOVE dev setup on package && Linting

3af0b87

ndelangen assigned ndelangen and renaudtertrais Nov 13, 2017

ndelangen added the addon: jest label Nov 13, 2017

Hypnosphi requested changes Nov 13, 2017

View reviewed changes

ndelangen added 3 commits November 14, 2017 00:40

Linting

f38a027

CHANGE jest config to exclude the example (failing) jest test for add…

37d3748

…on-jest

lockfile

b4c0d31

Merge branch 'master' into add-addon-jest

758c195

ndelangen added 2 commits November 14, 2017 16:20

Merge branch 'master' into add-addon-jest

d004bd7

FIX review comment

3c8c783

Hypnosphi approved these changes Nov 14, 2017

View reviewed changes

Merge branch 'master' into add-addon-jest

1073760

renaudtertrais added ci: do not merge in progress labels Nov 14, 2017

Add addon-jest to examples/cra-kitchen-sink

d185d1a

renaudtertrais force-pushed the add-addon-jest branch from cb3d4d6 to d185d1a Compare November 16, 2017 09:27

ndelangen and others added 5 commits November 18, 2017 21:16

Merge branch 'add-addon-jest' of github.com:storybooks/storybook into…

663d5ae

… add-addon-jest

IMRPOVE styling

ab0d84d

Merge branch 'master' into add-addon-jest

d0d0494

REFACTOR to glamorous

045bca1

no message

24b1982

Hypnosphi reviewed Nov 19, 2017

View reviewed changes

ndelangen added 3 commits November 19, 2017 08:42

FIX links in readme

1f2edf0

IMPROVE README

6dbbb34

CLEANUP: remove unneeded component

793b76e

ndelangen requested a review from shilman November 19, 2017 21:41

shilman requested changes Nov 19, 2017

View reviewed changes

Hypnosphi reviewed Nov 19, 2017

View reviewed changes

ndelangen added 5 commits November 21, 2017 08:27

IMPROVE readme

80bc824

Merge branch 'master' into add-addon-jest

d3ceba4

DELETE unneeded file

59fff75

Merge branch 'master' into add-addon-jest

7d95fae

CHANGE @storybook/addons to peerDependency && update versions

eb33a3e

ndelangen added 3 commits November 23, 2017 08:30

UPDATE snapshots

7206c93

UPDATE snapshots

9d83982

Merge branch 'master' into add-addon-jest

70d3424

Hypnosphi approved these changes Nov 23, 2017

View reviewed changes

ndelangen merged commit 5b86063 into master Nov 23, 2017

ndelangen deleted the add-addon-jest branch November 23, 2017 21:40

dependencies bot mentioned this pull request Apr 16, 2018

Update 63 dependencies from npm #3429

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add addon jest #2295

Add addon jest #2295

renaudtertrais commented Nov 12, 2017

Hypnosphi commented Nov 12, 2017 •

edited

Loading

Hypnosphi left a comment

Hypnosphi Nov 12, 2017

Hypnosphi Nov 12, 2017

Hypnosphi Nov 12, 2017

ndelangen Nov 13, 2017

renaudtertrais Nov 14, 2017

Hypnosphi Nov 12, 2017

Hypnosphi Nov 13, 2017

Hypnosphi Nov 13, 2017

codecov bot commented Nov 14, 2017 •

edited

Loading

ndelangen commented Nov 14, 2017

Hypnosphi commented Nov 14, 2017

ndelangen commented Nov 18, 2017

Hypnosphi commented Nov 18, 2017

Hypnosphi Nov 19, 2017

Hypnosphi Nov 19, 2017

shilman left a comment

Hypnosphi commented Nov 19, 2017

Hypnosphi Nov 19, 2017 •

edited

Loading

ndelangen Nov 20, 2017

Hypnosphi Nov 20, 2017

ndelangen Nov 21, 2017

ndelangen commented Nov 23, 2017

ndelangen commented Nov 23, 2017


		Brings Jest results in storybook.

		[![Storybook Jest Addon Demo](@storybook/addon-jest.gif)](https://@storybook/addon-jest-example.herokuapp.com/)

		@@ -0,0 +1,2 @@
		node_modules
		dist

Add addon jest #2295

Add addon jest #2295

Conversation

renaudtertrais commented Nov 12, 2017

What I did

How to test

Hypnosphi commented Nov 12, 2017 • edited Loading

Hypnosphi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Nov 14, 2017 • edited Loading

Codecov Report

ndelangen commented Nov 14, 2017

Hypnosphi commented Nov 14, 2017

ndelangen commented Nov 18, 2017

Hypnosphi commented Nov 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shilman left a comment

Choose a reason for hiding this comment

Hypnosphi commented Nov 19, 2017

Hypnosphi Nov 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndelangen commented Nov 23, 2017

ndelangen commented Nov 23, 2017

Hypnosphi commented Nov 12, 2017 •

edited

Loading

codecov bot commented Nov 14, 2017 •

edited

Loading

Hypnosphi Nov 19, 2017 •

edited

Loading