Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React to 16.1.0 #2285

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Update React to 16.1.0 #2285

merged 2 commits into from
Nov 10, 2017

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Nov 10, 2017

Release notes
Example app seems to work OK

I would also consider hoisting all those React devDependencies to root package manualy, so that they are more manageable. app/vue (and other non-react apps) still need direct dependencies to React though.

@storybooks/team, what do you think?

@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #2285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   22.14%   22.14%           
=======================================
  Files         268      268           
  Lines        5893     5893           
  Branches      699      712   +13     
=======================================
  Hits         1305     1305           
+ Misses       4066     4052   -14     
- Partials      522      536   +14
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 9.09% <0%> (ø) ⬆️
addons/info/src/components/Props.js 37.2% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6897edb...eb6083f. Read the comment docs.

@danielduan
Copy link
Member

Please test the crna react-native as well. React 16 isn't officially supported by crna, let alone 16.1: https://github.com/react-community/create-react-native-app/blob/master/VERSIONS.md

@Hypnosphi
Copy link
Member Author

This PR doesn't actually update anything in crna example. In app/react-native, it's devDependencies, so they don't get installed in apps, either.

I think that, given the concerns you brought up, we shouldn't update React in CRNA example in the same PR.

Any thoughts about the hoisting proposal?

@Hypnosphi
Copy link
Member Author

Hypnosphi commented Nov 10, 2017

Anyway, I checked that CRNA example works on this branch

@ndelangen ndelangen merged commit b5135ee into master Nov 10, 2017
@ndelangen ndelangen deleted the react-16.1 branch November 10, 2017 20:15
@Hypnosphi
Copy link
Member Author

@ndelangen how do you feel about moving all the react devDeps to root?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies maintenance User-facing maintenance tasks vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants