-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React to 16.1.0 #2285
Update React to 16.1.0 #2285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
=======================================
Coverage 22.14% 22.14%
=======================================
Files 268 268
Lines 5893 5893
Branches 699 712 +13
=======================================
Hits 1305 1305
+ Misses 4066 4052 -14
- Partials 522 536 +14
Continue to review full report at Codecov.
|
Please test the crna react-native as well. React 16 isn't officially supported by crna, let alone 16.1: https://github.com/react-community/create-react-native-app/blob/master/VERSIONS.md |
This PR doesn't actually update anything in crna example. In I think that, given the concerns you brought up, we shouldn't update React in CRNA example in the same PR. Any thoughts about the hoisting proposal? |
Anyway, I checked that CRNA example works on this branch |
@ndelangen how do you feel about moving all the react |
Release notes
Example app seems to work OK
I would also consider hoisting all those React
devDependencies
to root package manualy, so that they are more manageable.app/vue
(and other non-react apps) still need directdependencies
to React though.@storybooks/team, what do you think?