CLI test: always remove run
directory before exiting
#2201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
posttest
script runs only whentest
is successful, so there isrun
directory left after a CLI test failure. It's a part of workspaces (because we want to use linked packages in smoke tests), so if you runyarn
at some point later, this leads to an unintended change in lockfile.Here I use
trap
command to interceptEXIT
signal and run cleanup command while preserving the exit code