Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve incompatible addons logic #21883

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Apr 3, 2023

Closes #

What I did

Followup on #21863 where we check addon versions as well, to make this easier to maintain.

dev/build
image

automigrate
image

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Install an incompatible addon e.g. storybook-addon-outline
  3. Run dev/build/automigrate
  4. Get the warning

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the ci:merged Run the CI jobs that normally run when merged. label Apr 3, 2023
@shilman shilman merged commit 1666d5f into next Apr 3, 2023
@shilman shilman deleted the fix/incompatible-addons-message branch April 3, 2023 12:17
@kasperpeulen kasperpeulen mentioned this pull request Jul 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:merged Run the CI jobs that normally run when merged. cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants