Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Angular support on Windows when Storystore v7 is disabled #21830

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix Angular support on Windows when Storystore v7 is disabled #21830

merged 1 commit into from
Mar 30, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Mar 30, 2023 •
edited by ndelangen
Loading

Closes #21685

What I did

Fixed Angular support when storyStore v7 is disabled on Windows machines.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added bug ci:daily Run the CI jobs that normally run in the daily job. labels Mar 30, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-angular-with-storystore-v7-disabled branch from 076cc58 to 11ccdc3 Compare March 30, 2023 08:05
@ndelangen ndelangen merged commit 156898e into next Mar 30, 2023
@ndelangen ndelangen deleted the valentin/fix-angular-with-storystore-v7-disabled branch March 30, 2023 12:01
@shilman shilman mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: storyStoreV7: false breaks build
2 participants
@valentinpalkovic @ndelangen